[16.0][ADD] - sale_order_line_cancel #2357

sbejaoui · 2023-02-02T14:52:07Z

This module allows you to cancel the remaining quantity on sale order by adding
a dedicated action to sale lines. It also add two new fields to track canceled
and remaining to deliver quantities.

sbejaoui · 2023-02-02T14:54:27Z

cc/ @lmignon

lmignon

@sbejaoui I tested the odoo native behavior and it seems that this addon could be simplified and only provide the functionality in a specific context. On a sale order line, you can edit the quantity even if the SO is validated... IMO this behavior is dangerous and should be forbidden. Hopefully, an option is available into the settings to prevent the modification of quantities when the sale order is confirmed... It's only in the context where the modification is no more possible that this functionality makes sens and should be activated. Moreover, I've the feeling that all the custom code written to cancel the moves could be removed (and the dependency on OCA/stock-logistics-workflow#1202). When you change the qty on a confirmed line, Odoo takes the necessary steps to reflect this change in the picking chain. The only thing Odoo doesn't do is to prevent the cancel of quantities that are partially processed. Instead, it generate the return picking to revert this outgoing moves... I prefer to prevent the cancellation of qties already partially processed than adding more work to do by opertors. This behaviour could be a configurable option..

sbejaoui · 2023-02-06T15:58:33Z

@sbejaoui I tested the odoo native behavior and it seems that this addon ..

Thanks @lmignon for your input,

I understand your PoV, It's true that the change of the ordered quantity trigger the change/cancellation of the related moves.

This feature is meant to simplify the process and make it done with a simple click. It also keep the information of the initial ordered quantity and store the canceled quantity. The difference between the two fields may be helpful for sale reporting.

The dependency to OCA/stock-logistics-workflow#1202 is not a must. It's, IMO, a simpler way to get all sale line related moves instead of recursive loop.

lmignon · 2023-02-07T09:02:43Z

@sbejaoui I tested the odoo native behavior and it seems that this addon ..

Thanks @lmignon for your input,

I understand your PoV, It's true that the change of the ordered quantity trigger the change/cancellation of the related moves.

This feature is meant to simplify the process and make it done with a simple click. It also keep the information of the initial ordered quantity and store the canceled quantity. The difference between the two fields may be helpful for sale reporting.

The dependency to OCA/stock-logistics-workflow#1202 is not a must. It's, IMO, a simpler way to get all sale line related moves instead of recursive loop.

IMO, the functionality should only be available if the change of qty on confirmed sale order is activated..

lmignon

Some comment to add to the desciption

sale_cancel_remaining/readme/DESCRIPTION.rst

sale_cancel_remaining/wizards/__init__.py

jbaudoux

I did many tests and it works quite well. It restricts the possibility of changing the quantity on the sale order line but at least the cancelation is working properly while in standard odoo you can end-up with a very weird reverse picking as decreasing the sale order line quantity generates a negative move that is supposed to be merged with the original move but if it can't be assigned to the same picking, it will create a reverse picking.

A few remarks that would make this module more complete:

when you set the sales order back to quotation, product_qty_canceled on the lines should be reset to 0
I would display the cancel button on a locked sales order as you expect auto-locking to be enabled and you allow canceling the lines
When canceling the sales order, I would also write product_qty_remains_to_deliver in product_qty_canceled
If you don't generate the backorder of the outgoing picking, the product_qty_canceled on the lines should also increase

sale_cancel_remaining/views/sale_order_line.xml

sale_cancel_remaining/wizards/cancel_remaining_wizard.py

jbaudoux · 2023-03-30T18:00:44Z

The dependency to OCA/stock-logistics-workflow#1202 is not a must. It's, IMO, a simpler way to get all sale line related moves instead of recursive loop.

Just a side note that this way of finding the right moves of the chain is not safe as moves can be merged. For example, a single pick move could serve multiple delivery moves. This specific use case is covered by the stock_available_to_promise_release module which, in case you cancel the outgoing move, will unrelease the outgoing move and while unreleasing it, will go through the picking chain up to the source picking and split any merged move.

A solution would be that this module only cancel the outgoing move and have another module using the dependency to OCA/stock-logistics-workflow#1202 to propagate the cancelation.

You can maybe add this remark in a ROADMAP file.

sale_cancel_remaining/__manifest__.py

jbaudoux

Thanks for the improvements
LGTM

OCA-git-bot · 2023-04-03T07:59:22Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

sale_order_line_cancel/__manifest__.py

cyrilmanuel · 2023-11-23T07:37:06Z

ping @sbejaoui :)

Co-authored-by: Jacques-Etienne Baudoux <[email protected]>

cyrilmanuel · 2023-11-24T07:01:24Z

thank you @sbejaoui 👍 @rousseldenis can yo check the PR ?

Cancel remaining qty by running negative procurement orders to let odoo generate the appropriate operations

sale_order_line_cancel/README.rst

Co-authored-by: Jacques-Etienne Baudoux <[email protected]>

jbaudoux · 2024-02-21T08:23:45Z

sale_order_line_cancel/models/stock_move.py

+        for rec in sale_moves:
+            if rec.state != "cancel":
+                continue
+            rec.sale_line_id.product_qty_canceled = rec.product_uom_qty


This is not correct for the kits (mrp)

we should also ensure on sale.order.line that product_qty_canceled <= product_uom_qty - qty_delivered

jbaudoux · 2024-02-21T08:39:06Z

sale_order_line_cancel/models/sale_order.py

+
+    def _action_cancel(self):
+        orders = self.filtered(lambda s: s.state != "cancel")
+        orders_with_picking = orders.filtered("picking_ids")


Maybe this is better as in sale_stock they use qty_delivered_method:

Suggested change

orders_with_picking = orders.filtered("picking_ids")

orders_with_picking = orders.filtered(lambda o: any(line.qty_delivered_method == 'stock_move' for line in o.order_line)):

jbaudoux

We should also support dropship & kits
in regards of https://github.com/odoo/odoo/blob/16.0/addons/sale_mrp/models/sale_order_line.py#L33

cyrilmanuel · 2024-03-26T10:30:57Z

Hi @sbejaoui little ping, could you check about the comment of @jbaudoux ?

jbaudoux · 2024-05-08T15:04:28Z

See acsone#4

This reverts commit b5cd7f0.

Allows to check the cancellation on sale order line level Include normal sales (not locked)

cyrilmanuel · 2024-05-24T10:00:19Z

sale_order_line_cancel/security/sale_order_line_cancel.xml

+        <field name="perm_create" eval="1" />
+        <field name="perm_write" eval="1" />
+        <field name="perm_unlink" eval="1" />
+    </record>


is it possible to add entry for users in groups sales_team.group_sale_salesman ?
sale.order.line.cancel access own document

sbejaoui · 2024-11-14T08:34:44Z

sale_order_line_cancel/models/sale_order_line.py

+        for line in self:
+            if line._get_moves_to_cancel():
+                continue
+            line.product_qty_canceled = line.qty_to_deliver


@jbaudoux ,

The canceled quantity is not the same as the quantity to deliver because the quantity to deliver includes returned quantities.
For example, in an order of 10 units, if I deliver 8 and then cancel the remaining 2, and later my customer returns 2 units, I would expect the following values:

Quantity to deliver: 4

Quantity canceled: 2

rousseldenis · 2024-11-14T08:26:56Z

sale_order_line_cancel/wizards/sale_order_line_cancel.py

+    _description = "Cancel Remaining Wizard"
+
+    def _get_sale_order_line(self):
+        active_id = self._context.get("active_id")


_context is deprecated

Suggested change

active_id = self._context.get("active_id")

active_id = self.env.context.get("active_id")

sbejaoui force-pushed the 16.0-sale_cancel_remaining-sbj branch from 685f327 to da21d81 Compare February 2, 2023 14:53

sbejaoui force-pushed the 16.0-sale_cancel_remaining-sbj branch 3 times, most recently from 6418faf to f5d3431 Compare February 2, 2023 16:22

lmignon suggested changes Feb 6, 2023

View reviewed changes

sbejaoui force-pushed the 16.0-sale_cancel_remaining-sbj branch from f5d3431 to db0f8d6 Compare February 8, 2023 15:13

sbejaoui requested a review from lmignon February 8, 2023 15:13

sbejaoui force-pushed the 16.0-sale_cancel_remaining-sbj branch from db0f8d6 to 74a1b1f Compare February 8, 2023 15:40

lmignon approved these changes Feb 8, 2023

View reviewed changes

sale_cancel_remaining/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved

sale_cancel_remaining/wizards/__init__.py Outdated Show resolved Hide resolved

sbejaoui force-pushed the 16.0-sale_cancel_remaining-sbj branch 3 times, most recently from 0f051b2 to 23f56a1 Compare February 8, 2023 16:25

rousseldenis added the needs review label Feb 14, 2023

rousseldenis added this to the 16.0 milestone Feb 14, 2023

jbaudoux reviewed Mar 30, 2023

View reviewed changes

jbaudoux suggested changes Mar 30, 2023

View reviewed changes

sale_cancel_remaining/__manifest__.py Outdated Show resolved Hide resolved

sbejaoui force-pushed the 16.0-sale_cancel_remaining-sbj branch from 23f56a1 to a07abf4 Compare April 1, 2023 21:56

sbejaoui changed the title ~~[16.0][ADD] - sale_cancel_remaining~~ [16.0][ADD] - sale_order_line_cancel Apr 1, 2023

sbejaoui requested a review from jbaudoux April 1, 2023 21:57

sbejaoui force-pushed the 16.0-sale_cancel_remaining-sbj branch from a07abf4 to 34bf905 Compare April 1, 2023 22:08

jbaudoux approved these changes Apr 3, 2023

View reviewed changes

[ADD] - sale_order_line_cancel

6940f11

sbejaoui force-pushed the 16.0-sale_cancel_remaining-sbj branch from 34bf905 to 6940f11 Compare April 3, 2023 07:44

OCA-git-bot added approved ready to merge labels Apr 3, 2023

OCA-git-bot removed the ready to merge label Apr 19, 2023

jbaudoux suggested changes Oct 2, 2023

View reviewed changes

sale_order_line_cancel/__manifest__.py Outdated Show resolved Hide resolved

cyrilmanuel approved these changes Nov 16, 2023

View reviewed changes

cyrilmanuel mentioned this pull request Nov 23, 2023

[16.0] [ADD] - sale_order_line_cancel #2802

Closed

sbejaoui and others added 2 commits November 23, 2023 12:14

[ADD] sale_order_line_cancel: add authors

0c6c95c

Co-authored-by: Jacques-Etienne Baudoux <[email protected]>

[IMP] sale_order_line_cancel: use float_compare

c9d2339

cyrilmanuel approved these changes Nov 23, 2023

View reviewed changes

TDu mentioned this pull request Dec 18, 2023

[14.0][MIG] sale_order_line_cancel backport from 16 #2861

Open

sbejaoui requested a review from rousseldenis January 12, 2024 14:05

sbejaoui and others added 3 commits January 12, 2024 15:06

[IMP] trace sale line cancel

b2fbb08

[IMP] sale_order_line_cancel: check moves before cancel

7416524

[IMP] sale_order_line_cancel: Improve cancel process

b5cd7f0

Cancel remaining qty by running negative procurement orders to let odoo generate the appropriate operations

lmignon force-pushed the 16.0-sale_cancel_remaining-sbj branch from 8585123 to b5cd7f0 Compare February 12, 2024 09:48

jbaudoux reviewed Feb 21, 2024

View reviewed changes

sale_order_line_cancel/README.rst Outdated Show resolved Hide resolved

[FIX] readme

b79aebf

Co-authored-by: Jacques-Etienne Baudoux <[email protected]>

sbejaoui requested a review from jbaudoux February 21, 2024 08:12

jbaudoux reviewed Feb 21, 2024

View reviewed changes

rousseldenis added 2 commits May 15, 2024 10:39

Revert "[IMP] sale_order_line_cancel: Improve cancel process"

8e74d07

This reverts commit b5cd7f0.

[FIX] sale_order_line_cancel: Restore some features

483041b

Allows to check the cancellation on sale order line level Include normal sales (not locked)

cyrilmanuel approved these changes May 24, 2024

View reviewed changes

[IMP] sale_order_line_cancel: support kits

736014a

sbejaoui force-pushed the 16.0-sale_cancel_remaining-sbj branch from 29b4996 to 736014a Compare November 13, 2024 23:53

sbejaoui commented Nov 14, 2024

View reviewed changes

rousseldenis reviewed Nov 14, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][ADD] - sale_order_line_cancel #2357

[16.0][ADD] - sale_order_line_cancel #2357

sbejaoui commented Feb 2, 2023 •

edited

Loading

sbejaoui commented Feb 2, 2023

lmignon left a comment

sbejaoui commented Feb 6, 2023

lmignon commented Feb 7, 2023

lmignon left a comment

jbaudoux left a comment

jbaudoux commented Mar 30, 2023 •

edited

Loading

jbaudoux left a comment

OCA-git-bot commented Apr 3, 2023

cyrilmanuel commented Nov 23, 2023

cyrilmanuel commented Nov 24, 2023

jbaudoux Feb 21, 2024

jbaudoux Feb 21, 2024 •

edited

Loading

jbaudoux Feb 21, 2024

jbaudoux left a comment •

edited

Loading

cyrilmanuel commented Mar 26, 2024

jbaudoux commented May 8, 2024

cyrilmanuel May 24, 2024

sbejaoui Nov 14, 2024

rousseldenis Nov 14, 2024

	orders_with_picking = orders.filtered("picking_ids")
	orders_with_picking = orders.filtered(lambda o: any(line.qty_delivered_method == 'stock_move' for line in o.order_line)):

	active_id = self._context.get("active_id")
	active_id = self.env.context.get("active_id")

[16.0][ADD] - sale_order_line_cancel #2357

Are you sure you want to change the base?

[16.0][ADD] - sale_order_line_cancel #2357

Conversation

sbejaoui commented Feb 2, 2023 • edited Loading

sbejaoui commented Feb 2, 2023

lmignon left a comment

Choose a reason for hiding this comment

sbejaoui commented Feb 6, 2023

lmignon commented Feb 7, 2023

lmignon left a comment

Choose a reason for hiding this comment

jbaudoux left a comment

Choose a reason for hiding this comment

jbaudoux commented Mar 30, 2023 • edited Loading

jbaudoux left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Apr 3, 2023

cyrilmanuel commented Nov 23, 2023

cyrilmanuel commented Nov 24, 2023

jbaudoux Feb 21, 2024

Choose a reason for hiding this comment

jbaudoux Feb 21, 2024 • edited Loading

Choose a reason for hiding this comment

jbaudoux Feb 21, 2024

Choose a reason for hiding this comment

jbaudoux left a comment • edited Loading

Choose a reason for hiding this comment

cyrilmanuel commented Mar 26, 2024

jbaudoux commented May 8, 2024

cyrilmanuel May 24, 2024

Choose a reason for hiding this comment

sbejaoui Nov 14, 2024

Choose a reason for hiding this comment

rousseldenis Nov 14, 2024

Choose a reason for hiding this comment

sbejaoui commented Feb 2, 2023 •

edited

Loading

jbaudoux commented Mar 30, 2023 •

edited

Loading

jbaudoux Feb 21, 2024 •

edited

Loading

jbaudoux left a comment •

edited

Loading